Freegle Tech Report 19-09-30

Freegle Tech Report September 2019 Posts 27544-

General

Edward has been reworking the code for some time now and a pile of changes were implemented mid month with few problems, which were all promptly fixed. However if you have noticed anything unusual do let the Geeks know. Some of the job Ads were set too far away from the groups they were on. so Edward has done a fix until the company gets around to sorting it out.

Discourse

is being prepared for Tech group and should be live soon. As all mods should be able to access the new format, there will probably be some changes to the monthly report.

At the beginning of the month one of our servers was broken during an upgrade and down for a while. Some mails were stuck for a while but all sorted same day.

Development

(used by some mods to test changes)  did some strange things for a while until fixed. and we were asked to use the normal modtools for a while.

Direct

Chat Trying to check who asked for items I offered on the FD app I go into my posts and I can see the mark as taken and other buttons. The only sign of member replies is a chat bubble with a number, when I click it, the screen jumps but no messages show. I can't read messages on any of my posts using the app. A,Thanks, I'd broken the display of replies on the My Posts page, okay now. I was about to engage in a discussion with a member about one of my unwanted items using the app. I couldn't remember what the bell icon does or did so I pressed it. Immediately I'm aware that I have now nudged the member for no reason; Clicking it again did not work. Can we have the option to delete a message if it has not been read or acknowledged by the recipient? A. Deleting messages after send is possible, but only for a minute or two because after that they'll have been sent out by email if they weren't read. So I'm not sure that's worth it. There's an argument for putting a popup confirm on nudge the first time you use it. I'll look at that in the new version. Q. Went to Chit Chat, typed my comment in the box that says "Write a comment", clicked "comment"... and... NOTHING. A. Hit enter and it will go. Q We’ve had a run on various scammers the past few weeks the most recent for a PS4. Out of curiosity, and because of the changes you have made recently I thought I’d check that the chats had the warning notice that gets inserted when we approve someone as a scammer/spammer. None of the chats have the notification, and in the one there are 63 replies.. Is this broken or does it take a couple of hours to filter thru to them? A I've checked the code, and that warning goes out as a separate email - it doesn't appear in the chat that you can view on MT. As well as the email, if you impersonate one of the people who's been talking to a spammer then you'll see that the chat box is removed and a warning shown.

Fixes

• A bug found in Message counts on the approved posts was found and fixed.
• We had an intermittent fault whereby some messages approved by moderators appear on Modtools as "approved by" but then no name, whereas others say approved by {whoever).

Google link to one group was showing the information from the closed one.

Member settings For the new version of FD. Edward's been thinking about how to deal with the complexity of email settings, especially the fact that you might want different email settings on different groups. We can work out whether or not you have the same settings on all groups - which you would, of course, if you were only on one group, but also if you'd joined multiple groups but not changed the default settings. This is common for many members. We will have a simple screen for those members who if they decide to have something different can click on Advanced settings. Other members and most moderators will log in to the Advanced settings screen automatically,

Mod Tools

I was just updating some of our config messages and see we have a string for member ID $memberid which can be a bit impersonal and is sometimes just nos Do we have one that picks out their real name from their settings the your name bit see below so something like $memname  ??? A I've added $membername, but it probably won't be live until after I get back from holiday.

List of changes to the New Client Code for September

Use Axios proxy to avoid CORS issues
Not selecting chat properly on page load
Promise button in chat
Support promise/renege chat messages
Promise/unpromise from My Posts
Tidy reply layout Enable user ratings
Change way we expand messages on My Posts
Don't focus on chitchat post box as this isn't right on mobile
Nits
Add session fetch cache using store
Reinstate throttling of when we save store to local storage, for perf reasons
Button on My Posts to start chat
Show replies in My Posts
Hide/show old OFFERs
Tree shaking
More investigation of reducing bundle size
Defer loading of large FilePond file upload component until we actually need it
Fix to lazyloading and its dependencies
Show unread message count on My Posts
Minor bug
Switch from moment to dayjs to reduce bundle size
Shave a little off the bundle size
Fix some erros
Start work on My Posts
Post WANTED
Edit in chitchat
Improvements to event/volunteer ops on chitchat
Add remaining notification types
Trigger infinite scroll more rapidly
Fix colour on navbar
AboutMe
Fix performance issue navigating away from pages
Add chat message of type complete
Add chat message of type interested
Add chat message of type image
Improve styling of chat messages
Vuex reducer causing effective hang
Fix popup chat drag handle
Switch from dev to dbg server
Groups not saved in store correctly
Bug in autocomplete on Android
Add some debug for mobile
Reload route if click on same navbar link
Navbar fixes
) Leave button in Settings
Holiday email setting
Various notification settings
Fix mobile navbar
Per group email settings
Simple email settings
Account settings
Add Delete button for chitchat reply
Start work on Settings page
Combine chitchat highlighting and readmore
More login fixes
Add read more for long chitchat entries
Move login into separate component, which fixes a bug
Style tweaks to user profile
Popup user profile info from chat
Nudge in chat
Chat message of type Address
Don't show photo carousel if just one photo
Successful attempt at saving passwords
Spot when we're logged out on the server and update store
dd a couple of TODOs
) Nits
More small screen changes, mostly settings
More small screen changes, mostly chat
More Mobile improvements
Mobile improvements
Fix screen flicker on chitchat, scroll to bottom of chat
Restrict place autocomplete to regions
Fix SSR in Explore Group
Back to universal
Add photo to chitchat replies
Notification count tweaks
Add poll for notification count
Notification seen handling
User profile page
Join/leave buttons on Explore
Contact volunteers button
Explore regions
Explore page done
More work on Explore
Start Explore page
Landing page
Handle new users when posting
Reject and resubmit from chat/My Posts
Message Edit
Improve sizing on reply box
Share button
Withdraw on My Posts
Mark as TAKEN
Improve display on My Posts
Basic pruning for long threads
Click on chitchat to show user profile
) Chat store sync problems
Fetch user car crash

This is an automated list of the changes to the server code in the last months. If you have any questions about them, please reply to this mail. Here are the more important ones which would affect members:

• Blank page when loading jobs with a privacy blocker
  

...and here are the ones which are minor, or only affect volunteers in ModTools, or are internal changes that you wouldn't notice: Fromuid header not working
Change accepted SSL transports to make work against new web server
Make server side rendering work with webpack build
Scripts script not fully retired
Recent commits script should check both client and server repositories
UT fixes and more code removal
Better fix to chat review issue
Remove client-side code from this repository
Speedup: cache modmail count separately to avoid slow queries on logs table
Yahoo message sync should only look for recent messages to avoid slow query
) Add TODO to retire
Add header to chat notify messages to indicate UID of sender
Script to list emails of people who've asked for business cards
Email notifications for mod chats are linking to FD rather than MT
Add code for waste authorities
Speed up indexing/deindexing
Spam keyword check needs to be case-insensitive

Discourse

In line with the decision to leave Yahoo at the 2018 AGM and Freegle-Tech deciding on Discourse in November 2018 Chris has finally got things moving. He has submitted a proposal to the board to be paid to get the new system up to speed and help move groups across to Discourse, starting with Tech - which they've approved. He has already started work to ensure that the Discourse system data is backed up - and will set up a standby instance to take over (manually) if the first goes kaput. He will also work with Ed to improve the sign in system (via ModTools) so that it will work even if the main Freegle system is down. Once the technicalities are in place, my plan is to produce some documentation on the wiki to help you find your way round the new system and answer any questions. Eventually the plan is for Discourse to appear seamlessly within ModTools. Experienced Discourse user James C has volunteered to continue his help running the system. He's hoping to get the technicalities sorted in about a week, along with a first version of the instructions. At that point I suggest giving a week's notice of the move. I hope that the wiki will answer any questions in due course. Chris Geeks

Remove messages from the search index once they're older than 30 days and haven't been reposted. We need to do this to save disk space.
Back to [[Freegle Tech Report 19-08-31|Freegle Tech Report 19-08-31] Forward to Freegle Tech Report 19-10-31